Repository navigation
Conversation
ligeia
marked this pull request as ready for review
October 14, 2026 03:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a Claude-assisted (Opus 5.5 - High effort) change to the Actions page on Harmony that compares tracklengths between the selected ISRC provider and the MusicBrainz release.
On the Release Actions page, ISRCs from the provider are matched to MusicBrainz tracks by position only. If the track order differs between MB and the provider, the MagicISRC link still submits every ISRC, and MagicISRC doesn’t check anything beyond whether the ISRC already exists. This has resulted in many ISRCs being added to the wrong recordings.
This PR adds a warning under the MagicISRC action when, for any track with a pending ISRC:
the MB and provider track lengths differ by more than 2 seconds, or
either side has no track length, so there’s nothing to compare.
The warning names the affected tracks and links to both the MB release and the provider release. Submission is not blocked.
Deliberately minimal for now. Possible follow-ups, if wanted: title comparison, a side-by-side tracklist table, or leaving flagged ISRCs out of the MagicISRC link.