feat: 土台の部品 11 個と、軸 88〜94 の決定 - #17
Merged
Merged
Conversation
Add ThemeProvider, Portal, VisuallyHidden, AspectRatio, Icon, Skeleton, Image, Collapsible, Transition, ScrollArea and Container. Select, Dialog, Popover, Tooltip and Drawer read their presentation and portal container defaults from ThemeProvider. Figure draws its image through Image. The comparison stories for axes 88–94 are kept in this commit as the point of decision; they are removed in the next commit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Write ADR-0113 (ThemeProvider, Portal, VisuallyHidden, AspectRatio) and ADR-0114–0120 for the decided axes, with comparison images. Update principles 1, 3, 5 and 11, the backlog and the ADR index, and remove the comparison stories (decided at 8693e86). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
README の「土台」にある部品と、画像・読み込み中・ページの枠の部品を作りました。見た目は Storybook の比較(軸 88〜94)で決め、ADR-0113〜0120 に記録しています。
足した部品
focusableで本文へ飛ぶリンクにもanimation: sweep(既定)・sweep-viewport・pulseerrorText。寸法のない画像は読み込むまで 16:9。Figure の画像も Image にしたappearance(plain・open-filled・filled・divided)とindicator(end・start)edgeShadow・scrollbarコミット
8693e86: 部品と比較ストーリー(決めた時点。git checkout 8693e86 && pnpm storybookで比較を開けます)5e47e5c: ADR・原則(1・3・5・11)・backlog・索引・比較画像。比較ストーリーを消しました確かめたこと
pnpm typecheck・pnpm lint・pnpm format:check・pnpm test(216 件)が通ること入れていないもの
🤖 Generated with Claude Code