feat(cli): add API v2 AgentInstance workflows by codyhartsook · Pull Request #2559 · kagent-dev/kagent

codyhartsook · 2026-08-25T18:06:11Z

Summary

Adds API v2 CLI commands for AgentTemplate discovery and AgentInstance lifecycle and invocation
Adds typed AgentInstance and upstream A2A clients over the shared gRPC connection
Connects through configured gRPC or a temporary controller port-forward, with optional TLS
Removes the legacy client-side agent project workflow while retaining mcp

Note that of the 64 files changed, 35 were removals from the legacy CLI project workflow ; no server-side APIs or controllers are removed.

This is the first of three related CLI PRs:

#2559 : API v2 CLI foundation: template/instance discovery, create/delete, invoke/streaming, JSON output, and quarantining legacy commands.
#2605 : TUI: browse AgentInstances, load history, and chat through the same A2A path as invoke.
#2606 : Cleanup: simplify main.go and align the command structure with agentregistry.

Suspend and resume are deliberately not exposed by this CLI work.

Related to #2366 and the K13 CLI cutover in docs/plans/api-v2-execution-plan.md.

Test plan

make -C go test
go test ./core/cli/...
make -C go lint
make -C go build
AgentTemplate and AgentInstance CLI smoke test against a local installation

EItanya

Initial review, I'm still looking for more simplifications, but this is a good start

Signed-off-by: Cody Hartsook <cody.hartsook@solo.io>

EItanya · 2026-08-28T14:55:26Z

+	checkServer    func(context.Context, *client.ClientSet) error
+	commandContext func(context.Context, string, ...string) *exec.Cmd


I really really hate callbacks unless absolutely necessary. Can you explain this component and why we need these?

Yeah, fair point. These callbacks mainly exist for tests and make the production path harder to follow. I’ll remove the runtime wrapper, call the real functions directly.

Removed these

EItanya · 2026-08-28T14:57:45Z

+func buildKagentCLI(t *testing.T) string {
+	t.Helper()
+	_, source, _, ok := goruntime.Caller(0)
+	if !ok {
+		t.Fatal("locate interaction test source")
+	}
+	moduleRoot := filepath.Clean(filepath.Join(filepath.Dir(source), "../../.."))
+	binary := filepath.Join(t.TempDir(), "kagent")
+	command := exec.CommandContext(t.Context(), "go", "build", "-o", binary, "./core/cli/cmd/kagent")
+	command.Dir = moduleRoot
+	if output, err := command.CombinedOutput(); err != nil {
+		t.Fatalf("build CLI: %v\n%s", err, output)
+	}
+	return binary
+}


I'd rather not build from the tests, can we use pre-built?

Done, the E2E target builds the CLI once and passes it through KAGENT_E2E_CLI. CI uses the same path

EItanya · 2026-08-28T14:57:59Z

 	}
 }

+func TestCLIAgentInstanceDiscoveryAndInvoke(t *testing.T) {


All e2e tests should be prefixed with TestE2E

Updated the two E2E tests added by this PR to use TestE2E

EItanya · 2026-08-28T14:58:14Z

+		"--kagent-grpc-url", target,
+		"--kagent-grpc-tls=false",


Why do these flags need the kagent prefix?

Removed the prefix from the new gRPC flags: --grpc-url, --grpc-tls, --grpc-ca-file, and --grpc-server-name.

EItanya · 2026-08-28T14:59:17Z

 	}
 }

+func TestCLIAgentInstanceDiscoveryAndInvoke(t *testing.T) {


Can we group all of the cli tests in the same file

both CLI E2E tests are now in cli_catalog_lifecycle_test.go

EItanya · 2026-08-28T15:00:34Z

-type Config struct {
-	KAgentURL            string        `mapstructure:"kagent_url"`
-	KAgentGRPCURL        string        `mapstructure:"kagent_grpc_url"`
-	KAgentGRPCTLS        bool          `mapstructure:"kagent_grpc_tls"`
-	KAgentGRPCCAFile     string        `mapstructure:"kagent_grpc_ca_file"`
-	KAgentGRPCServerName string        `mapstructure:"kagent_grpc_server_name"`
-	Namespace            string        `mapstructure:"namespace"`
-	OutputFormat         string        `mapstructure:"output_format"`
-	Verbose              bool          `mapstructure:"verbose"`
-	Timeout              time.Duration `mapstructure:"timeout"`
-}


I think we still need this config to be embedded in the other cmd configs.

type AgentInstanceConfig struct { BaseConfig }

Something like the above

I ended up addressing this in PR #2606 by reading shared connection and output flags at each command boundary, so BaseConfig would no longer be needed. Would it be okay to leave this as-is here and handle it in that follow-up or prefer we address here?

Signed-off-by: Cody Hartsook <cody.hartsook@solo.io>

github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Aug 25, 2026

codyhartsook marked this pull request as ready for review August 25, 2026 23:57

codyhartsook requested a review from a team as a code owner August 25, 2026 23:57

EItanya requested changes Aug 26, 2026

View reviewed changes

Comment thread go/core/cli/internal/tui/dialogs/mcp_server_wizard.go Outdated

Comment thread go/core/cli/internal/cli/agentinstance/lifecycle.go Outdated

Comment thread go/core/cli/internal/config/config.go Outdated

codyhartsook requested a review from EItanya August 26, 2026 16:39

codyhartsook force-pushed the api-v2-cli-pr1-split branch from 85151d8 to f4d2a51 Compare August 27, 2026 16:13

codyhartsook added 6 commits August 27, 2026 11:38

feat(cli): add v2 agent instance clients

8fcd5fb

Signed-off-by: Cody Hartsook <cody.hartsook@solo.io>

feat(cli): discover and invoke agent instances

e830033

Signed-off-by: Cody Hartsook <cody.hartsook@solo.io>

feat(cli): manage agent templates and instances

af6d782

Signed-off-by: Cody Hartsook <cody.hartsook@solo.io>

refactor(cli): remove legacy agent and BYO commands

ac51cca

Signed-off-by: Cody Hartsook <cody.hartsook@solo.io>

refactor(cli): narrow agent instance client surface

247db17

Signed-off-by: Cody Hartsook <cody.hartsook@solo.io>

fix(cli): complete API v2 integration cleanup

2c71aee

Signed-off-by: Cody Hartsook <cody.hartsook@solo.io>

codyhartsook force-pushed the api-v2-cli-pr1-split branch from f2bdea9 to 2c71aee Compare August 27, 2026 19:23

This was referenced Aug 27, 2026

feat(cli): rebuild the TUI around AgentInstances #2605

Open

refactor(cli): simplify command composition #2606

Open

github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Aug 27, 2026

EItanya reviewed Aug 28, 2026

View reviewed changes

EItanya and others added 2 commits August 28, 2026 11:05

Merge branch 'main' into api-v2-cli-pr1-split

e82df54

fix(cli): address review feedback

e6ed469

Signed-off-by: Cody Hartsook <cody.hartsook@solo.io>

codyhartsook requested a review from Charlesthebird as a code owner August 28, 2026 17:42

codyhartsook marked this pull request as draft August 28, 2026 17:50

EItanya and others added 4 commits August 28, 2026 13:54

Merge branch 'main' into api-v2-cli-pr1-split

d4d8229

fix(a2a): resolve API package alias after merge

915af7b

Signed-off-by: Cody Hartsook <cody.hartsook@solo.io>

Merge branch 'main' into api-v2-cli-pr1-split

37d068b

fix(cli): forward model token to A2A requests

0517f3d

Signed-off-by: Cody Hartsook <cody.hartsook@solo.io>

codyhartsook marked this pull request as ready for review August 28, 2026 19:58

codyhartsook requested a review from EItanya August 28, 2026 19:59

		checkServer func(context.Context, *client.ClientSet) error
		commandContext func(context.Context, string, ...string) *exec.Cmd

Uh oh!

Conversation

codyhartsook commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

EItanya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codyhartsook commented Aug 25, 2026 •

edited

Loading