Repository navigation
dnszone: sort zone master list in status - #1005
Merged
Merged
Conversation
We can't guarantee that the zone masters list has the same order as declared in the spec. Because of that, we can sort the master list before writing it in the status to have a deterministic behavior.
winiciusallan
force-pushed
the
sort-dnszone-masters
branch
from
October 21, 2026 14:28
685c9b1 to
d15fe37
Compare
mandre
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't guarantee that the zone masters list has the same order as declared in the spec. Because of that, we can sort the master list before writing it in the status to have a deterministic behavior.
More context #1004 (comment)