Skip to content

Update lcobucci/jwt add on library support for PS tokens - #950

Open
SvenRtbg wants to merge 2 commits into
jsonwebtoken:masterfrom
SvenRtbg:patch-3
Open

Update lcobucci/jwt add on library support for PS tokens#950
SvenRtbg wants to merge 2 commits into
jsonwebtoken:masterfrom
SvenRtbg:patch-3

Conversation

@SvenRtbg

Copy link
Copy Markdown

@jonathanp-okta wrote on #852:

Hey @SvenRtbg, thanks for digging into this!

After reviewing the official docs, PS256/PS384/PS512 are intentionally kept out of the core lcobucci/jwt package and live in the separate lcobucci/jwt-rsassa-pss package. So the current false values on the main entry are actually correct — a user who runs composer require lcobucci/jwt won't get PS support.

The right approach would be to add a brand new entry for lcobucci/jwt-rsassa-pss with ps256/ps384/ps512: true. Would you be up for opening a new PR for that instead? Happy to review it quickly.

Closing this one for now.

So here we are again, after the previous attempt was closed without merging nor explanation in #938.

SvenRtbg added 2 commits July 16, 2026 18:25
Added support details and author information for lcobucci/jwt-rsassa-pss.

Replaces PR jsonwebtoken#852 as recommended.
@jonathanp-okta

Copy link
Copy Markdown
Contributor

Thanks for reopening this, @SvenRtbg — sorry the question on #938 went unanswered.

Technically this looks right to me: PS256/384/512 support lives in the separate lcobucci/jwt-rsassa-pss package, not core lcobucci/jwt (which correctly still shows false for those flags on master), so a new entry is the correct shape — consistent with what I suggested on #852.

@jcmartinezdev — could you share why #938 was closed? Want to make sure there's a clear answer either way (merge, or a policy reason to close) so this doesn't stall again.

One independent note: the stars field is auto-populated by CI (generate:library-data) off gitHubRepoPath on every deploy and the weekly cron — no entry in libraries-next.json currently carries a checked-in value. Mind dropping the hardcoded "stars": 0? It's optional on the model and would just get overwritten anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants