feat(m16): retire PipelineRun escape hatches - #21
Merged
Conversation
Flask always creates StackRuns; STACKRUN_VIA_CRD=false is ignored. generate-run.sh --pipeline-run is removed. Helm no longer opts out. Co-authored-by: John Menke <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flask always creates StackRun CRs.
--pipeline-runandSTACKRUN_VIA_CRD=falseare removed.What changed
_create_run/GET /api/runsalways use StackRuns.STACKRUN_VIA_CRDis ignored.approved_byis 200 / operatorPendingApproval(same as GUI). Newman still gets apipelinerunalias equal to the StackRun name.generate-run.sh --pipeline-runandGENERATE_PIPELINE_RUN=trueexit with a removed-hatch error. The raw PipelineRun YAML path is gone.orchestrationService.stackrunViaCrdis gone;STACKRUN_VIA_CRDis hard-coded"true"for mixed-image rollouts.run-cluster-ci.sh --skip-operatorno longer setsSTACKRUN_VIA_CRD=false.Tests
create_stackrunand StackRun specs.verify-m4-stacks-and-labels.shchecks--pipeline-runis rejected.Still open in M16: spoken demo narration/MP4 rebuild (
docgen rebuild-after-audio); S34 intercept E2E stays parked.