Polish desktop loop: premium review gate and MCP bring-up - #12
Open
jmjava wants to merge 1 commit into
Open
Conversation
Point Cursor/Copilot/Claude MCP at run_mcp.sh so empty interpolations cannot hide .env. Treat blank OLLAMA_* as unset. Spell out accept / rewrite / reject in client instructions, tool docs, and system prompts before live GPU use. Local still does not apply. Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
September 7, 2026 15:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polish the desktop product loop before live GPU measurement. Local still only proposes. The premium agent is the apply gate (
accept/rewrite/reject).Bring-up
scripts/run_mcp.sh(loads.env, no blank${env:NAME}clobber, clear miss if.venvis missing).OllamaSettings.from_envandgetenv_nonemptytreat empty interpolations as unset (also avoidsint("")onOLLAMA_NUM_CTX)._load_dotenvuses the samemerge_dotenvhelper as the safety checker.Review loop (no GPU required)
Client instructions now match the eval apply gate:
.cursor/rules/local-coding-slm.mdcCLAUDE.md.github/copilot-instructions.mdThey say: attach
{path, content}files, fast then one format/structure repair then strong, fences not diffs,local_reviewis notes only, apply the full set or none,ERROR:means Ollama/tunnel is down, Cloud Agent withoutlocal_*tools does the work itself.Generation system prompts prefer fenced files.
local_reviewprompt says notes cannot approve.Local checks: 110 tests passed, plus fixture eval, scripted orchestration, and stub
--orchestrate.Not in this PR
--backend livecorpus rates (workstation next)local_apply(still forbidden)