Fail closed when scene-spec layout gaps coerce bools to 1.0 - #148
Merged
Conversation
first_row_title_buff / row_gap / column_gap still went through float(), so true became 1.0 and looked like a valid gap. Require YAML numbers when present; missing keys keep compile defaults. Co-authored-by: jmjava <jmjava@gmail.com>
ruff green; pytest 821 passed, 1 skipped; docgen benchmark meets baseline. Co-authored-by: jmjava <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #147 typed
wait_word/run_time/ sizes /page_transition_run_time. Layout gaps still went throughfloat()at compile.first_row_title_buff: truebecame 1.0 and looked like a valid gap. A quoted"0.6"raised at compile, not atvalidate_scene_spec.Change
layout.first_row_title_buff/row_gap/column_gapmust be YAML numbers (not bool)MIN_TITLE_ROW_BUFF) stay warningsGate
ruff check src/ tests/greenpytest tests/— 821 passed, 1 skippeddocgen benchmarkmeetssrc/docgen/benchmark_data/baseline.json(no clock change; no--update-baseline)Out of scope
wait_wordsemantic drift)Milestone:
milestones/scene-spec-layout-gaps.md