Fail closed when merge settings coerce bool tunables - #142
Merged
Conversation
Config.from_yaml already requires YAML numbers for temperature and max_context_bytes. The merge helpers still used float()/int()/str(), so true became temperature 1.0, a 1-byte context window, or model \"True\". Use require_yaml_number / require_yaml_string so bools raise. Missing values still use defaults; temperature 0 stays 0. Co-authored-by: jmjava <jmjava@gmail.com>
ruff green; pytest 794 passed, 1 skipped; docgen benchmark meets baseline. Co-authored-by: jmjava <jmjava@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config.from_yamlalready requires YAML numbers fortemperature/max_context_bytes(#117). The merge helpers still usedfloat()/int()/str()oncfg.raw.boolis a subclass ofint:temperature: truebecame 1.0,max_context_bytes: truebecame a 1-byte window,model: truebecame"True".Wizard generate-narration and
scene-spec-generateboth go through these merges.This PR uses
require_yaml_number/require_yaml_string. Missing/null still uses defaults.temperature: 0still stays 0.See
milestones/merge-settings-numerics.md.