Repository navigation
Add friendly messages for the remaining namespace errors - #84
Merged
Merged
Conversation
Thirteen namespace errors had no entry in getUserFriendlyMessage and printed "unknown error": UserNamespacesDisabled, OverlayFsUnavailable, ProfileNotFound, WorkspaceNotFound, MountPrivateError, MountTmpfsError, MountProcError, MountOverlayError, ChrootError, SetuidError, ExecError, ForkError and MknodError. Running a command that is not in the profile printed "unknown error" ahead of the detail that explained it. Give each one a message that names what failed. Add a test that walks every EnvError and fails if one still maps to "unknown error", so a new error cannot be added without a message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thirteen namespace errors had no entry in getUserFriendlyMessage and
printed "unknown error": UserNamespacesDisabled, OverlayFsUnavailable,
ProfileNotFound, WorkspaceNotFound, MountPrivateError, MountTmpfsError,
MountProcError, MountOverlayError, ChrootError, SetuidError, ExecError,
ForkError and MknodError. Running a command that is not in the profile
printed "unknown error" ahead of the detail that explained it.
Give each one a message that names what failed. Add a test that walks every
EnvError and fails if one still maps to "unknown error", so a new error
cannot be added without a message.