Repository navigation
Carry namespace setup details across the fork to the parent - #83
Merged
Merged
Conversation
forkAndEnterEnv runs namespace setup in a forked child and sent the parent only the error name over the setup pipe. The subject and details the setup code now sets on the Context stayed in the child, so mere dev build and generation realizers reported "failed to fork and enter env: UnshareError" with no operation, path or cause. The child now clears the diagnostics it inherited, then sends the error name, subject and details, cut to fit a 2048 byte report. The parent decodes the report and restores the subject and details on its Context. The build orchestrator and the generation realizer keep those details and fall back to the error name only when setup reported nothing. Fixes #66
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forkAndEnterEnv runs namespace setup in a forked child and sent the
parent only the error name over the setup pipe. The subject and details
the setup code now sets on the Context stayed in the child, so mere dev
build and generation realizers reported "failed to fork and enter env:
UnshareError" with no operation, path or cause.
The child now clears the diagnostics it inherited, then sends the error
name, subject and details, cut to fit a 2048 byte report. The parent
decodes the report and restores the subject and details on its Context.
The build orchestrator and the generation realizer keep those details and
fall back to the error name only when setup reported nothing.
Fixes #66