Repository navigation
Fix double free when exec fails in a namespace - #82
Merged
Merged
Conversation
execCommand freed the argument strings, argv and the default command itself after execve returned, then returned ExecError, which ran the errdefer blocks that free the same memory again. Running a command that does not exist in the profile crashed with a general protection exception and exit status 128 instead of reporting ExecError. Return ExecError and let the errdefer blocks do the freeing. Add a test that runs a nonexistent absolute path; it crashed before this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
execCommand freed the argument strings, argv and the default command
itself after execve returned, then returned ExecError, which ran the
errdefer blocks that free the same memory again. Running a command that
does not exist in the profile crashed with a general protection exception
and exit status 128 instead of reporting ExecError.
Return ExecError and let the errdefer blocks do the freeing. Add a test
that runs a nonexistent absolute path; it crashed before this change.