Repository navigation
Add CONTRIBUTING.md with the coding standards - #80
Merged
Merged
Conversation
Document the standards the code is expected to follow: errors carry their cause to the CLI, allocators come from the Context, library code reports through the Context and ui events and not stdout, the CLI layer holds no business logic, how tests and allocation-failure sweeps are written, and what a cache key must cover.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the standards the code is expected to follow: errors carry their
cause to the CLI, allocators come from the Context, library code reports
through the Context and ui events and not stdout, the CLI layer holds no
business logic, how tests and allocation-failure sweeps are written, and
what a cache key must cover.