Repository navigation
Replace a stale cached source when its hash no longer matches the recipe - #79
Merged
Merged
Conversation
When a recipe source's contents and blake3 change, the file in the shared source cache fails the hash check and is queued for download. The download is verified in a .part file, but without force it is not moved over the existing cache file, so the stale file stays. The new workspace copy then conflicts with it and the build stops with "existing workspace source conflicts with cached source" until the source cache is cleared by hand. Set force on the download when the recipe declares a blake3, so the verified file replaces the stale one. Add a test with a stale cache entry. Fixes #78
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a recipe source's contents and blake3 change, the file in the shared
source cache fails the hash check and is queued for download. The download
is verified in a .part file, but without force it is not moved over the
existing cache file, so the stale file stays. The new workspace copy then
conflicts with it and the build stops with "existing workspace source
conflicts with cached source" until the source cache is cleared by hand.
Set force on the download when the recipe declares a blake3, so the
verified file replaces the stale one. Add a test with a stale cache entry.
Fixes #78