Repository navigation
Key build phases on the sources directory contents - #77
Merged
Merged
Conversation
Phase scripts can read every declared source and recipe companion file through MERE_SOURCES_DIR, but the phase cache key only covered the first source unpacked into the build directory. Changing a helper source and its blake3 alone restored the old install output and produced an identical package archive. Hash the sources directory once per build and fold it into the source identity passed to the phase key. Add a regression test that changes only a helper read through MERE_SOURCES_DIR, keeps the build cache, and checks the package archive changes and the install phase is not restored. Fixes #74
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase scripts can read every declared source and recipe companion file
through MERE_SOURCES_DIR, but the phase cache key only covered the
first source unpacked into the build directory. Changing a helper source
and its blake3 alone restored the old install output and produced an
identical package archive.
Hash the sources directory once per build and fold it into the source
identity passed to the phase key. Add a regression test that changes only
a helper read through MERE_SOURCES_DIR, keeps the build cache, and checks
the package archive changes and the install phase is not restored.
Fixes #74