Repository navigation
Make build phase error handling portable - #68
Merged
Merged
Conversation
Build phases run under /bin/sh, where ERR traps are not universally supported. Use an exit trap so shells such as Dash can run phases while preserving failure status after the debug shell exits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build phases fail before executing on shells such as Dash because /bin/sh does not universally support ERR traps. Use a portable exit trap that starts the debug shell only on failure and preserves the phase's original exit status, even if the debug shell exits unsuccessfully.
Validated with Zig 0.16.0:
zig build test --summary allreports 758 passed, 22 skipped, and zero failures. Checked success, command failure, and explicit nonzero exit under Dash and Bash; successful phases skip the handler and failing phases retain their status. Full isolated package builds remain unverified.