Repository navigation
feat(routines): "Add a step" searches steps and chores, and makes new ones - #357
Merged
Merged
Conversation
… ones
The routine editor's step dropdown is now a search box. It lists library
steps not yet in the routine, then chores ("From your chores"); a chore
picked becomes a library step with its title and icon, unrelated to the
chore afterward. Text that names no step and no chore offers
Create step "...", which opens the same New step dialog as the Steps tab
(name and icon) with the name filled in.
The step dialog moves out of RoutinesTab into RoutineStepDialog so both
places share it. Its submit stops at its own form: React events cross the
portal, and the editor's form would otherwise save the routine too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #356
"Add a step" in the routine editor is now a search box:
Create step "...", which opens the same New step dialog as the Steps tab (name and icon) with the name filled in.RoutinesTabintoRoutineStepDialog, shared by both. Its submit stops at its own form, since React events cross the portal and would otherwise save the routine too.Client only, no server change. New unit tests for the option list (
routineStepOptions). Running in production on our instance.