Repository navigation
fix(chores): the week calendar scrolls on a phone - #355
Merged
Merged
Conversation
On a phone each day keeps 104px, so the week is wider than the panel and is meant to scroll sideways. The grid was only as wide as the panel, though, and its overflow: hidden (for the rounded border) clipped the days past it, so there was nothing to scroll: Wednesday on, today included, could not be seen. The grid is now as wide as its days on a phone.
adamecker
pushed a commit
to adamecker/HomeGlow
that referenced
this pull request
Oct 30, 2026
… into test/all-combined Upstream photoDetails migration renumbered 37 -> 43 (fork already uses 37 for routineStreakBase); fork migration numbering 28-42 preserved, including Google Tasks registrations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a phone, the week calendar in Admin → Family → Chores (#353) cut off Wednesday through Saturday, today included, and couldn't be scrolled to.
The phone layout keeps 104px per day and means to scroll sideways, but the grid was only as wide as the panel. The days overflowed inside it, and its
overflow: hidden(for the rounded border) clipped them, so the scrolling box around it had nothing to scroll. On a phone the grid is now as wide as its days (minWidth: 7 * 104). Desktop and portrait are unchanged.Tested on my install at 390px wide: Sunday shows first, the calendar scrolls to Saturday, and the page doesn't scroll sideways. Before the fix, Saturday sat at 666px on a 390px screen and a swipe didn't move it. Desktop still fits without scrolling. Client 856/856, i18n and build pass.