Repository navigation
Conversation
…hes. A non-UTF-8 200 from the first backend aborted lw_tx_status instead of trying the next one. get_transaction_hex already fell through; both callers now use esplora_http_get.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lw_tx_statusandget_transaction_hexnow shareesplora_http_get, so a bad response from one Liquid backend falls through to the next in both paths.UnicodeDecodeErrorbefore the next backend was tried. That case now falls through, matching the refund hex fetch.electrum_urlstill usesget_tx.Test plan
TestTxStatusBackendFallbackandTestChainAccessin a Linux container (33 passed)aqua liquid tx-statusfor tx8392a675…15724(confirmed, 2115 confs)get_transaction_hexfor the same tx (45426hex chars, starts02000000)