Skip to content

Add support for media keys functionality - #4

Open
gabrielmar wants to merge 1 commit into
jamiepine:mainfrom
gabrielmar:main
Open

Add support for media keys functionality#4
gabrielmar wants to merge 1 commit into
jamiepine:mainfrom
gabrielmar:main

Conversation

@gabrielmar

@gabrielmar gabrielmar commented Aug 13, 2026

Copy link
Copy Markdown

This PR introduces support for media keys (play, pause, next, previous)

Current Limitation: Was unable to locate the correct raw key codes for macOS media keys

Summary by CodeRabbit

  • New Features
    • Added support for volume mute, volume up, and volume down controls.
    • Added media playback controls for next track, previous track, stop, and play/pause.
    • Enabled these controls on Linux and Windows platforms.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f0ea7942-5c1b-4e46-8674-9664b5eed210

📥 Commits

Reviewing files that changed from the base of the PR and between a1b3385 and 39fae61.

📒 Files selected for processing (3)
  • src/key.rs
  • src/platform/linux/keycodes.rs
  • src/platform/windows/keycodes.rs

📝 Walkthrough

Walkthrough

The public Key enum now defines volume and media playback controls. Linux evdev and Windows virtual-key mappings convert platform key codes to these variants.

Changes

Media key support

Layer / File(s) Summary
Add media key variants
src/key.rs
The public Key enum adds mute, volume, track, stop, and play/pause variants.
Map platform media codes
src/platform/linux/keycodes.rs, src/platform/windows/keycodes.rs
Linux evdev and Windows virtual-key codes map to the new Key variants.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: ⚪ Minimal · up to 39fae

The PR adds media-key variants without supplied evidence of a compatibility violation or concrete production impact; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding support for media key functionality.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant