fix(strategy29): own the automatic summary and restore reliable panel dragging - #285
Conversation
|
@codex review Review the current head for Strategy29-owned automatic summary, the shared public read capability with privately held gateway credentials, Unicode symbols, staged updates and pointer capture across chart iframes. The large legacy fixture files are exact published immutable test inputs; feature source is under src/. All 920 unit/DOM and 68 Playwright tests passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76ebd8a185
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Review the current head for Strategy29-owned automatic summary, the shared public read capability with privately held gateway credentials, Unicode symbols, staged updates and pointer capture across chart iframes. The large legacy fixture files are exact published immutable test inputs; feature source is under src/. All 920 unit/DOM and 68 Playwright tests passed. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Return the cross-timeframe summary panel, polling lifecycle and saved position to the Strategy29 userscript and start it automatically. Remove the summary toggle. Keep the existing Strategy27 installation's gateway settings as the single credential source, exposing only allowlisted public read responses through a bounded shared transport.
Fix panel dragging across the TradingView iframe with primary pointer capture, and accept canonical Unicode market names in Strategy29 status and events. Preserve the existing installation identities and staged-upgrade behavior without duplicate panel owners. Publish Strategy27 0.6.0 and Strategy29 0.5.0.
Validation: all 925 unit/DOM tests and all 68 Playwright tests passed. The new iframe-drag regression failed before the fix and passes with pointer release, subsequent iframe interaction and saved-position restoration. Generated upgrade tests also verify one-time handoff of the last host-owned position, invalid-provider isolation and no repeated position migration. Real Python gateway responses pass the final artifact contract. Both affected builds, all Binance syntax checks, metadata verification and
git diff --checkpassed. Existing production-page source was inspected; live acceptance of these new artifacts follows publication and exact Tampermonkey synchronization.