feat(signals): share gateway configuration across strategy modules - #283
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f3ca661b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Strategy27 and Strategy29 previously required separate gateway settings in separate userscript stores. The existing Strategy27 installation now hosts the CorsairQuant remote modules and supplies one private gateway URL and secret to both. Its installed name, namespace, update URLs and existing private credential keys are retained. Strategy29's standalone script owns only local chart detection; a strict non-sensitive migration transfers missing panel coordinates and module preferences once, in either load order.
The shared menus follow the page language. A disabled summary remains discoverable without requests. Explicit server-disabled and backend-unavailable responses clear current readiness while preserving history. Module initialization, visibility and request ownership remain isolated from Strategy27 consumers. Local marker alignment diagnostics now include requested and returned timestamps without changing detection or failure recovery.
Validation:
Pair with the server's fixed Strategy29 gateway routes before installing this client. Production Strategy29 monitoring, gateway backend and notifications remain disabled. Tampermonkey exact synchronization and live acceptance are pending publication.
Artifacts: Strategy27 host 0.5.0 SHA-256 4fd2a513a1fab78e238aad09a0f2241a915fa646241cc8c43a935cbed5354719; Strategy29 local 0.4.0 SHA-256 de8d145f23cc04000af39732733cc8a3bed2e66eed7bd7f351796fff38e4a388.
Independent automatic updates use a companion readiness handshake. A legacy Strategy29 remote owner retains its panel and polling until both installations have updated and the page reloads. New companions display a localized update notice while waiting for the host. Regression tests execute the exact released 0.3.0 artifact, cover both load orders and completed preference migrations, and reject same-page reuse of the legacy runtime.