Remove very old deprecated code from com.jme3.input package - #2753
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes several deprecated methods and constants from the jMonkeyEngine core input system, specifically within AbstractJoystick, ChaseCamera, InputManager, and the Joystick interface. These removals clean up the API by eliminating legacy code that had been superseded by newer implementations. I have no feedback to provide.
e790ccf to
045d849
Compare
|
I'd probably keep this around for now, unless it is problematic |
How long? It's been deprecated for a long time. |
|
I'd say until it becomes a cost maintaining it |
|
I disagree, it's valuable to tidy up apis after 10 years of being deprecated... There is likely zero cost to removing it. People read code far more than it's written, and people are having to read dead code is a cost. There is already a cost for it just existing. |
2 participants
This stuff has been deprecated for a very long time. I think we should remove it now.