Repository navigation
Bound optional Fo pre-commit verification - #72
Merged
Merged
Conversation
krystophny
marked this pull request as ready for review
October 27, 2026 17:46
krystophny
force-pushed
the
fix/bounded-fo-hook
branch
from
October 27, 2026 17:48
3100c59 to
2d44693
Compare
krystophny
enabled auto-merge
October 27, 2026 17:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
fo hook pre-commit --boundedin the optional shared hook and update the installer checksum so it accepts the changed script. The bounded command is implemented by merged Fo #232.Verified: isolated installation passes on main, fails on the original PR with
SHA256 mismatch: pre-commit, and passes with the updated checksum. Behavioral controls verify bounded dispatch, Fo failure propagation, native-hook chaining, unsupported-Fo hints, and staged-manifest detection. Bash syntax and whitespace checks pass. The repository Python suite passes: 7 passed, 15 skipped, using the existing libneo environment plus the declared f90nml dependency in a temporary path.Reference-data and optional-extension tests remain skipped by the existing suite. The installed Fo lacks the hook command; dispatch was tested with a controlled executable, and Fo's bounded verification engine was not rebuilt or requalified here. This changes the shared hook source; it does not install it globally.
Chris&AI