Skip to content

refactor: replace hardcoded admin flash messages with constants #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itheCreator1 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −8
Open

refactor: replace hardcoded admin flash messages with constants #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions constants/messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@ const TICKET_MESSAGES = {
NOT_FOUND: 'Ticket not found',
UNAUTHORIZED_ACCESS: 'You do not have permission to access this ticket',
STATUS_CHANGED: 'Ticket status updated successfully',
PRIORITY_CHANGED: 'Ticket priority updated successfully',
INTERNAL_CREATED: 'Internal ticket created successfully',
ADMIN_CREATED: 'Admin ticket created successfully',
DEPARTMENT_TICKET_CREATED: 'Department ticket created successfully',
};

const COMMENT_MESSAGES = {
Expand Down
11 changes: 3 additions & 8 deletions routes/admin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ router.post(
req.ip,
buildAuditContext(req)
);
successRedirect(req, res, 'Status updated successfully', `/admin/tickets/${req.params.id}`);
successRedirect(req, res, TICKET_MESSAGES.STATUS_CHANGED, `/admin/tickets/${req.params.id}`);
} catch (error) {
logger.error('Status update error', { ticketId: req.params.id, error: error.message });
next(error);
Expand All @@ -147,7 +147,7 @@ router.post(
req.ip,
buildAuditContext(req)
);
successRedirect(req, res, 'Priority updated successfully', `/admin/tickets/${req.params.id}`);
successRedirect(req, res, TICKET_MESSAGES.PRIORITY_CHANGED, `/admin/tickets/${req.params.id}`);
} catch (error) {
logger.error('Priority update error', { ticketId: req.params.id, error: error.message });
next(error);
Expand Down Expand Up @@ -268,12 +268,7 @@ router.post(
department: ticket.reporter_department,
});

successRedirect(
req,
res,
'Department ticket created successfully',
`/admin/tickets/${ticket.id}`
);
successRedirect(req, res, TICKET_MESSAGES.DEPARTMENT_TICKET_CREATED, `/admin/tickets/${ticket.id}`);
} catch (error) {
logger.error('Admin department ticket creation error', {
adminId: req.session.user.id,
Expand Down
Loading