Feature/new waveform format - #195
Open
SBlokhuizen wants to merge 4 commits into
Open
SBlokhuizen wants to merge 4 commits into
SBlokhuizen wants to merge 4 commits into
Conversation
SBlokhuizen
force-pushed
the
feature/new-waveform-format
branch
from
September 17, 2026 14:55
798bcfa to
a4f1b53
Compare
SBlokhuizen
force-pushed
the
feature/new-waveform-format
branch
6 times, most recently
from
September 21, 2026 09:41
ae0d4e5 to
9d82c85
Compare
SBlokhuizen
force-pushed
the
feature/new-waveform-format
branch
from
September 21, 2026 09:47
9d82c85 to
3997316
Compare
SBlokhuizen
marked this pull request as ready for review
September 21, 2026 09:51
SBlokhuizen
requested review from
MireilleSchneider and
maarten-ic
as code owners
September 21, 2026 09:51
Collaborator
Author
|
@DaanVanVugt Could you have a look at this PR? Thanks! |
| self.pipe = streams.Pipe() | ||
|
|
||
| self.pane = pn.pane.HoloViews(sizing_mode="stretch_both") | ||
| self.no_preview_message = pn.pane.Markdown( |
Collaborator
There was a problem hiding this comment.
is this relevant for the format changes? could be split in another pr to tame this monster a bit. or mention it in the pr desc
Collaborator
Author
There was a problem hiding this comment.
It is relevant for this PR, because this should be shown if a referenced waveform is selected which is not a time trace, because then we can not visualize it as a waveform.
SBlokhuizen
force-pushed
the
feature/new-waveform-format
branch
from
September 21, 2026 14:14
bf7eb98 to
ab5cbaa
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to simplify the waveform format and actor, compared to the version used currently in the PDS.
Changes to waveform YAML syntax
inputandoutputfields.{port: <name>}values, only URIs are supported{type: import/reference, ref: ...}tendency to{copy: <import>}. References are no longer mixable with analytic tendencies in the same list.Changes to waveform Actor
timeis read, which determines which time slice to output the waveforms onto.Example of the new format for a prescribed transport run in the PDS:
Details