Repository navigation
chore: Book QA の book-formatter pin を cff9fcf へ更新 - #256
Merged
Merged
Conversation
ootakazuhiko
marked this pull request as ready for review
August 24, 2026 11:24
Collaborator
Author
|
@codex review |
There was a problem hiding this comment.
Pull request overview
Book QA ワークフローが参照する itdojp/book-formatter の immutable ref(commit SHA)を、監査済みの cff9fcf8bae31140f07b358d314fc64173cb7013 へ更新し、formatter 側の依存関係セキュリティパッチ(js-yaml)を取り込むための変更です。Issue #253 の受入基準どおり、差分は checkout の ref 1 行のみになっています。
Changes:
.github/workflows/book-qa.ymlのitdojp/book-formattercheckoutrefを69eb5c1...→cff9fcf...に更新
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #253
active Book QA の
itdojp/book-formatterimmutable ref を、監査済みのcff9fcf8bae31140f07b358d314fc64173cb7013(fix(deps): update js-yaml security patches (#117))へ更新します。Scope
最終的な
origin/main...HEADの committed diff は.github/workflows/book-qa.ymlの checkoutref一行だけです。69eb5c12f5a750b65614bc9bbbc3d7abd5aa6f6ccff9fcf8bae31140f07b358d314fc64173cb7013本文、consumer dependency/lockfile、build contract、Pages設定、workflow behaviorは変更していません。先行dependency PR #255の通常squash mergeを、このbranchへ通常merge commitで取り込みました(rebase / force pushなし)。
Exact head
1c4b0c0efdd4cc60cdbb251e78970b7173290d3dVerification
66b8d84ca7ad47dc7b4a78852a80f5c28945a29anpm ci --ignore-scripts: successnpm audit --audit-level=high: 0 vulnerabilitiesnpm run test:light: successnpm ci --ignore-scripts/ high audit 0git diff --check: successCI / review gate
32721370213(exact head; completion待ち)32721370241(success)0/0/0、exact-head Codex/Copilot review完了後にReady化します。