Skip to content

fix(release): account for native Windows payload files - #35

Merged
eyeveil merged 1 commit into
mainfrom
fix/windows-native-payload-budget
Nov 6, 2026
Merged

eyeveil merged 1 commit into
mainfrom
fix/windows-native-payload-budget

Conversation

@eyeveil

@eyeveil eyeveil commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Why

The synced Windows nightly stops at the payload guard because it contains 86 files against a limit of 80. Native Windows builds include compile-cache and node-pty files that upstream's Linux cross-build omits.

What changed

  • Raise the Windows payload limit to 100 and explain the native-build allowance. Keep every runtime and payload validation.

Scope

  • Covers the Windows release file-count guard.
  • Leaves package contents and unrelated duplicate files unchanged.

Tradeoffs

The failed native build includes these 20 files beyond the cross-build allowance. The cache filenames vary with the compiled modules.

resources/server-compile-cache/
  08028184, 0d808419, 0e1fed73, 15554626, 1c7dc616, 4437dca0,
  44405521, 456bb7d0, 4a79d28d, 580fe337, 74a49860, 879ff0f5,
  885a0409, c03bff9a, eac08cf3, ed152236, f1650c0a, manifest.json
resources/server.asar.unpacked/node_modules/node-pty/build/Release/conpty/
  conpty.dll, OpenConsole.exe

Excluding the cache from the count would leave its growth unchecked. Removing unrelated duplicates would require broader runtime checks and leave the current payload exactly at 80, with no headroom.

Blast Radius

Only the Windows packaging guard changes. The measured 86-file payload fits with 14 files of headroom, while native-load and bundle checks remain required.

Verification

  • vp test run scripts/build-desktop-artifact.test.ts passed all 50 tests.
  • vp run check:changed HEAD passed format, lint, knip, typecheck, and focused tests on the uncommitted one-file diff.
  • Compared successful and failed CI inventories. Growth is 13 transcription DLLs, one FFI addon, and three cache files. Real Windows runtime loading remains for the release build.

Model and harness: GPT-6.1-Sol (implementation) via Codex and Claude Opus 5.5 (investigation) via Claude Code in T3 Code.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS labels Nov 6, 2026
@greptile-apps

greptile-apps Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The change appears safe to merge.

Summary

Raises the Windows payload file limit from 80 to 100.

  • The Windows payload check now allows up to 100 files.

Reviews (1) · Last reviewed commit: "fix(release): account for native Windows..." · Reviewed by Greptile

@eyeveil
eyeveil merged commit ba531fd into main Nov 6, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant