Repository navigation
fix(release): account for native Windows payload files - #35
Merged
Merged
Conversation
[Medium impact] The change appears safe to merge. SummaryRaises the Windows payload file limit from 80 to 100.
Reviews (1) · Last reviewed commit: "fix(release): account for native Windows..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The synced Windows nightly stops at the payload guard because it contains 86 files against a limit of 80. Native Windows builds include compile-cache and node-pty files that upstream's Linux cross-build omits.
What changed
Scope
Tradeoffs
The failed native build includes these 20 files beyond the cross-build allowance. The cache filenames vary with the compiled modules.
Excluding the cache from the count would leave its growth unchecked. Removing unrelated duplicates would require broader runtime checks and leave the current payload exactly at 80, with no headroom.
Blast Radius
Only the Windows packaging guard changes. The measured 86-file payload fits with 14 files of headroom, while native-load and bundle checks remain required.
Verification
vp test run scripts/build-desktop-artifact.test.tspassed all 50 tests.vp run check:changed HEADpassed format, lint, knip, typecheck, and focused tests on the uncommitted one-file diff.Model and harness: GPT-6.1-Sol (implementation) via Codex and Claude Opus 5.5 (investigation) via Claude Code in T3 Code.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.