[benchmarker] Add step instability detection - #1613
Open
BenjaminPelletier wants to merge 1 commit into
Open
Conversation
BenjaminPelletier
marked this pull request as ready for review
August 5, 2026 05:35
mickmis
approved these changes
Aug 11, 2026
mickmis
left a comment
mickmis
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Mostly just some clarifications.
In addition, do you have evidence of this feature working correctly?
Contributor
There was a problem hiding this comment.
Is the inclusion of this gitignore intentional?
| stop_event.set() | ||
| await asyncio.sleep(0.5) | ||
|
|
||
| if stop_event.is_set() or stability_time is None: |
Contributor
There was a problem hiding this comment.
Before if this evaluates to true, the next step (Summarize activity during step) was not executed. After it is executed. I'm unsure whether that's an issue or intended though?
| PERIODIC_STATUS_PERIOD_S = 30.0 | ||
|
|
||
|
|
||
| async def run_user_ramp_load( |
Contributor
There was a problem hiding this comment.
This function is becoming challenging to follow. Consider breaking it down? Or in a future PR that touches it again?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing with #1566, this PR adds the concept of throughput instability criteria. Currently, there are throughput stability criteria which must be satisfied to move onto the data collection portion of the step. This PR adds corresponding criteria indicating that throughput stability will not be achieved (e.g., the system is so overloaded it will be unable to recover) so that the step can be aborted.
Since steps can now be terminated without having collected a valid sample, the throughput stability time is made optional on the report and a StepTerminationReason is added.