Feature/lab2 Tikhon Makeev - #1539
Open
tikhonmakeev wants to merge 5 commits into
Open
tikhonmakeev wants to merge 5 commits into
tikhonmakeev wants to merge 5 commits into
Conversation
Signed-off-by: tikhonmakeev <t.makeev@edu.centraluniversity.ru>
Signed-off-by: tikhonmakeev <t.makeev@edu.centraluniversity.ru>
Signed-off-by: tikhonmakeev <t.makeev@edu.centraluniversity.ru>
Signed-off-by: tikhonmakeev <t.makeev@edu.centraluniversity.ru>
There was a problem hiding this comment.
🟡 Changes recommended
Verification evidence and documentation issues remain unresolved.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a Lab 2 Git internals exercise report and a reusable pull-request template.
Changes:
- Documents Git object inspection, reflog recovery, tagging, rebasing, and bisecting.
- Adds the standard PR template and checklist.
File summaries
| File | Summary | Review findings |
|---|---|---|
submissions/lab2.md |
Lab 2 evidence and explanations | 2 moderate verification issues and 4 nits concerning command evidence, Markdown fencing, wording, and bisect explanation. |
.github/pull_request_template.md |
Standard PR description template | No review comments. |
Review details
Suppressed comments (3)
submissions/lab2.md:440
find .git/objects -type f | wc -lcounts every regular file below.git/objects, including pack and index files, so it cannot establish how many loose objects exist or that the remaining objects are packed. Usegit count-objects -v(or inspectobjects/pack) before making that distinction.
find says 151 files - some of them are loose objects. The other arrived from the clone can be packed in .pack file (to save space)
submissions/lab2.md:32
- This
git cat-file -poutput is pasted as raw Markdown, so the.gitignoreand README lines beginning with#, headings, and tables are parsed as part of the submission instead of displayed as literal command output. That makes the later lab headings and evidence structure render incorrectly; wrap each command output in a fenced code block.
PS C:\Users\tihon\ui-cources\DevOps-Intro> git cat-file -p 1c0a1e94b7bbdd951f456cda51af6b8484cc3cee
submissions/lab2.md:522
- The lab requires a 3–4 sentence explanation of the bisect result, but this section contains only two sentences. Add at least one sentence connecting the recorded good/bad checks to why
f285ede...is the first bad commit.
### Why log2(N)
Bisect is binary search. Every result we find throws away half of the remaining candidates: bad means the bug exists now or exists before that commit, so everything after dont care.
good means the bug came later -- what was before is out. It turns N tests into log2(N) tests
- Files reviewed: 2/2 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+463
to
+467
| PS C:\Users\tihon\ui-cources\DevOps-Intro> git tag -v "v0.1.0-lab2-${env:USER}" # verifies signature; "Good" expected | ||
| object 9f41b7deb32343a831b5e47c61533fbc7c0ce67d | ||
| type commit | ||
| tag v0.1.0-lab2-tikhonmakeev | ||
| tagger tikhonmakeev <t.makeev@edu.centraluniversity.ru> 1789073659 +0300 |
| 151 | ||
|
|
||
| ### What I see | ||
| HEAD is not a commit, it is one line of text reffering branch I am on right now. Switching branches basically rewrites this file |
| ## Bonus | ||
|
|
||
| PS C:\Users\tihon\ui-cources\DevOps-Intro>git bisect log | ||
| ```git bisect start |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Changes
Testing
Checklist
git log --show-signature)submissions/labN.mdupdated