Skip to content

Feature/lab2 Tikhon Makeev - #1539

Open
tikhonmakeev wants to merge 5 commits into
inno-devops-labs:mainfrom
tikhonmakeev:feature/lab2
Open

tikhonmakeev wants to merge 5 commits into
inno-devops-labs:mainfrom
tikhonmakeev:feature/lab2

Conversation

@tikhonmakeev

@tikhonmakeev tikhonmakeev commented Sep 10, 2026

Copy link
Copy Markdown

Goal

Changes

Testing

Checklist

  • Title is a clear sentence (≤ 70 chars)
  • Commits are signed (git log --show-signature)
  • submissions/labN.md updated

Signed-off-by: tikhonmakeev <t.makeev@edu.centraluniversity.ru>
Signed-off-by: tikhonmakeev <t.makeev@edu.centraluniversity.ru>
Signed-off-by: tikhonmakeev <t.makeev@edu.centraluniversity.ru>
Signed-off-by: tikhonmakeev <t.makeev@edu.centraluniversity.ru>
Copilot AI lite review requested due to automatic review settings September 10, 2026 23:45
@tikhonmakeev tikhonmakeev changed the title Feature/lab2 Feature/lab2 Tikhon Makeev Sep 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Verification evidence and documentation issues remain unresolved.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds a Lab 2 Git internals exercise report and a reusable pull-request template.

Changes:

  • Documents Git object inspection, reflog recovery, tagging, rebasing, and bisecting.
  • Adds the standard PR template and checklist.
File summaries
File Summary Review findings
submissions/lab2.md Lab 2 evidence and explanations 2 moderate verification issues and 4 nits concerning command evidence, Markdown fencing, wording, and bisect explanation.
.github/pull_request_template.md Standard PR description template No review comments.
Review details

Suppressed comments (3)

submissions/lab2.md:440

  • find .git/objects -type f | wc -l counts every regular file below .git/objects, including pack and index files, so it cannot establish how many loose objects exist or that the remaining objects are packed. Use git count-objects -v (or inspect objects/pack) before making that distinction.
find says 151 files - some of them are loose objects. The other arrived from the clone can be packed in .pack file (to save space)

submissions/lab2.md:32

  • This git cat-file -p output is pasted as raw Markdown, so the .gitignore and README lines beginning with #, headings, and tables are parsed as part of the submission instead of displayed as literal command output. That makes the later lab headings and evidence structure render incorrectly; wrap each command output in a fenced code block.
PS C:\Users\tihon\ui-cources\DevOps-Intro> git cat-file -p 1c0a1e94b7bbdd951f456cda51af6b8484cc3cee

submissions/lab2.md:522

  • The lab requires a 3–4 sentence explanation of the bisect result, but this section contains only two sentences. Add at least one sentence connecting the recorded good/bad checks to why f285ede... is the first bad commit.
### Why log2(N)

Bisect is binary search. Every result we find throws away half of the remaining candidates: bad means the bug exists now or exists before that commit, so everything after dont care.
good means the bug came later -- what was before is out. It turns N tests into log2(N) tests
  • Files reviewed: 2/2 changed files
  • Comments generated: 3
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread submissions/lab2.md
Comment on lines +463 to +467
PS C:\Users\tihon\ui-cources\DevOps-Intro> git tag -v "v0.1.0-lab2-${env:USER}" # verifies signature; "Good" expected
object 9f41b7deb32343a831b5e47c61533fbc7c0ce67d
type commit
tag v0.1.0-lab2-tikhonmakeev
tagger tikhonmakeev <t.makeev@edu.centraluniversity.ru> 1789073659 +0300
Comment thread submissions/lab2.md
151

### What I see
HEAD is not a commit, it is one line of text reffering branch I am on right now. Switching branches basically rewrites this file
Comment thread submissions/lab2.md
## Bonus

PS C:\Users\tihon\ui-cources\DevOps-Intro>git bisect log
```git bisect start
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants