Properly serialize fields when emit_fields option is enabled - #160
Open
hackermondev wants to merge 1 commit into
Open
hackermondev wants to merge 1 commit into
hackermondev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
emit_fieldsoption is enabled, it doesn't properly differentiate between default fields (that should be emitted) and optional fields (which should only be emitted if they have a value); there's a mismatch inwrite_struct_serialize_startandwrite_serialize_fieldon whether optional fields are emitted, resulting in an invalidlengthpassed toSerializer::serialize_structwhich breaks serialization.It only emits
rankingSignalsif the field has a value, but when calculating the length, it always counts the field.This change ensures only default fields are emitted when
emit_fieldsis enabled.