Conversation
Clippy 1.98 adds useless_borrows_in_formatting, which fires on every Visitor the generator writes: `&FIELDS` where `FIELDS` is already a `&[&str]`. Any crate that includes generated code and builds with -Dwarnings fails on it. Fixes influxdata#157.
Author
|
Duplicate of #158, which predates this and adds tests; closing in its favour. The two CI failures on both are unrelated to the change: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clippy 1.98 adds
useless_borrows_in_formatting, which fires on everyVisitorthe generator writes:&FIELDSwhereFIELDSis already a&[&str]. Any crate that includes generated code and builds with-Dwarningsfails on it.Fixes #157.
Checked with
cargo +1.98.1 clippy -p pbjson-test --no-deps --all-targets -- -Dwarnings: 16 errors on main, none with this.