Fix remaining TXOP duration calculation - #1126
Conversation
TxopProcedure::getRemaining() incorrectly returns the elapsed TXOP duration while the TXOP is active. This causes callers to treat spent time as the remaining transmission budget. Return the configured TXOP limit minus the elapsed duration while preserving the existing zero clamp after expiry. Add a focused unit test covering the inactive state, the full limit at startup, partial elapsed time, exact expiry, post-expiry clamping, and the state after ending the TXOP.
The corrected TxopProcedure::getRemaining() now reports the remaining TXOP budget instead of elapsed duration. HcfFs::hasMoreTxOps() therefore makes different frame-continuation decisions in the MIPv6 roaming Wi-Fi scenario. Record the deterministic trajectory produced by the fix: 7ed8-bee3/~tNlb replaces c8dc-27c2/~tNlb in the focused regression baseline. The narrow fingerprint test passed after the update.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| /examples/ipv6/mipv6/, -f omnetpp.ini -c Handover -r 0, 70s, aa29-a8c5/~tNlb, PASS, wireless EthernetMac | ||
| /examples/ipv6/mipv6/, -f omnetpp.ini -c RouteOptimizationTwoCNs -r 0, 60s, 068b-23aa/~tNlb, PASS, wireless EthernetMac | ||
| /examples/ipv6/mipv6roaming/, -f omnetpp.ini -c Roaming -r 0, 70s, c8dc-27c2/~tNlb, PASS, wireless EthernetMac | ||
| /examples/ipv6/mipv6roaming/, -f omnetpp.ini -c Roaming -r 0, 70s, 7ed8-bee3/~tNlb, PASS, wireless EthernetMac |
There was a problem hiding this comment.
🟡 A stored reference result for a wireless roaming test was replaced even though that test cannot be affected by the change
The expected result for the mobile-IPv6 roaming test is overwritten with a new value (7ed8-bee3/~tNlb at tests/fingerprint/mipv6-refactoring.csv:13) even though that simulation never exercises the changed prioritized-transmission code, so a genuine unrelated change in behavior is silently accepted as the new baseline.
Impact: A real behavior change (or nondeterminism) in the roaming scenario is hidden, and future runs will be compared against a value that was never justified.
Why the roaming scenario cannot exercise TxopProcedure
TxopProcedure only exists inside Edcaf, which is instantiated inside Hcf, and Hcf is created only when qosStation is true (src/inet/linklayer/ieee80211/mac/Ieee80211Mac.ned:86 and :116). examples/ipv6/mipv6roaming/omnetpp.ini never sets qosStation (it configures **.wlan*.mac.dcf.channelAccess.cwMin), so the non-QoS DCF path is used and TxopProcedure::getRemaining() is never called.
Consistently, the actually TXOP-sensitive baselines (e.g. tests/fingerprint/examples.csv:657-661, tests/fingerprint/showcases.csv:316-317,344) were left untouched — which is plausible because the only caller, src/inet/linklayer/ieee80211/mac/framesequence/HcfFs.cc:65, evaluates getRemaining() > 0 and old/new expressions differ only at the exact expiry instant. That makes the single updated non-QoS row inconsistent with the rest of the change.
Prompt for agents
The fingerprint baseline for /examples/ipv6/mipv6roaming/ (Roaming config) was changed from c8dc-27c2/~tNlb to 7ed8-bee3/~tNlb in tests/fingerprint/mipv6-refactoring.csv, but this scenario runs the non-QoS DCF path (qosStation defaults to false in src/inet/linklayer/ieee80211/mac/Ieee80211Mac.ned and the ini never enables it), so TxopProcedure is not even instantiated and the getRemaining() fix cannot alter it. Re-run the roaming fingerprint on the base commit and on this branch to determine whether the difference is real; if the hash differs without this code change, the scenario is nondeterministic or the change came from elsewhere and the baseline update should be reverted/investigated rather than re-recorded. Also confirm whether the genuinely TXOP-dependent baselines (examples.csv wireless/qos and adhoc/qos rows, showcases.csv wireless/qos, txop, blockack, aggregation rows) still pass.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Root cause: bookkeeping failure to the July 802.11 on-wire serialization batch, which updated the duplicate examples.csv row’s data-sensitive fingerprint but omitted mipv6-refactoring.csv.
Historical isolation found the real cause:
- Commit 632e460 reproduces c8dc-27c2.
- The sequence-control endian change still reproduces c8dc-27c2.
- Adding the association-ID allocation changes it exactly to 7ed8-bee3.
- The AP now writes allocated AIDs into association/reassociation responses at Ieee80211MgmtAp.cc (line 266). Event count remains 59,408, proving this is serialized packet-content change, not changed scheduling.
The corresponding examples.csv row (line 385) already contains the correct network fingerprints; tplx, ~tNl, and ~tND all passed. Its graphical tyf ingredient differed under fake-GUI execution, but that ingredient is unrelated and intentionally unreliable.
I also reran all 20 relevant QoS/HCF baselines across examples.csv and showcases.csv, including the dedicated TXOP showcase. Every baseline passed unchanged, so the TXOP fix requires no additional fingerprint updates.
There was a problem hiding this comment.
@levy ready for your review and approval
|
Hi Miguel,
@levy is on holiday this week. I expect he will get back to you when he
returns. Thanks for the contributions!
Gábor
…On Sun, Aug 16, 2026, 16:20 Miguel González-López ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/fingerprint/mipv6-refactoring.csv
<#1126 (comment)>:
> @@ -10,7 +10,7 @@
# MIPv6 example — the primary test
/examples/ipv6/mipv6/, -f omnetpp.ini -c Handover -r 0, 70s, aa29-a8c5/~tNlb, PASS, wireless EthernetMac
/examples/ipv6/mipv6/, -f omnetpp.ini -c RouteOptimizationTwoCNs -r 0, 60s, 068b-23aa/~tNlb, PASS, wireless EthernetMac
-/examples/ipv6/mipv6roaming/, -f omnetpp.ini -c Roaming -r 0, 70s, c8dc-27c2/~tNlb, PASS, wireless EthernetMac
+/examples/ipv6/mipv6roaming/, -f omnetpp.ini -c Roaming -r 0, 70s, 7ed8-bee3/~tNlb, PASS, wireless EthernetMac
@levy <https://github.com/levy> ready for your review and approval
—
Reply to this email directly, view it on GitHub
<#1126?email_source=notifications&email_token=ABDUIPKOLMJF72EJODBRK335KGYIXA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOJUGYZDOMJZGYZKM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#discussion_r3791837151>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABDUIPMJQZ43SSVFY7R5M235KGYIXAVCNFSNUABCKJSXA33TNF2G64TZHMYTCMRWGMZTWSLTON2WKOZVGE2TKNRVGIYTAOFBOYBA>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/ABDUIPI4N2PPNQQKXPMYG335KGYIXA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOJUGYZDOMJZGYZKM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ>
and Android
<https://github.com/notifications/mobile/android/ABDUIPIQL47JNZVGFDI7RI35KGYIXA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIOJUGYZDOMJZGYZKM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ>.
Download it today!
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
2 participants
Summary
TxopProcedure::getRemaining()to return the unspent TXOP durationRoot cause
While a TXOP was active,
getRemaining()returnedsimTime() - start, which is the elapsed duration. Callers therefore received the spent portion of the TXOP as though it were the remaining transmission budget.The corrected expression returns
start + limit - simTime()before expiry and zero afterward.Impact
Code that uses the remaining TXOP duration can now make scheduling decisions from the actual available budget. The inactive-state behavior is unchanged: querying before the TXOP starts or after it ends still raises a runtime error.
Validation
source ./setenv -q && make MODE=release -j$(nproc)source ./setenv -q && inet_run_unit_tests -m release -f 'Ieee80211TxopProcedure_1\.test'The focused test covers the inactive state, the full limit at startup, partial elapsed time, exact expiry, post-expiry clamping, and the state after ending the TXOP.