You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: unwrap Tailwind layers for older chrome versions - #720
Updated stylesheet processing to unwrap eligible CSS layers, including nested layers, and omit empty layers. This changes how layered styles are prepared before they are applied. No new user-facing controls or features are included.
Reviewing files that changed from the base of the PR and between c1edb77 and 2846046.
📒 Files selected for processing: 2
immichFrame.Web/postcss-unwrap-layers.js
immichFrame.Web/postcss.config.js
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
📝 Walkthrough
The change adds a PostCSS plugin that unwraps leaf @layer rules and registers the plugin alongside Tailwind’s PostCSS plugin.
Changes: PostCSS layer handling
Layer / File(s)
Summary
Layer unwrapping and registration immichFrame.Web/postcss-unwrap-layers.js, immichFrame.Web/postcss.config.js
The new unwrapLayers plugin unwraps leaf @layer rules, removes empty ones, and repeats traversal to process nested layers. The PostCSS configuration loads it alongside Tailwind’s PostCSS plugin.
No actionable display regression is established in the inspected styles. The change is mergeable after normal build and visual checks.
Pre-merge checks: 5
Passed checks: 5 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: unwrapping Tailwind layers to address compatibility with older Chrome versions.
Linked Issues check
Issue #714 reports a display regression on older WebOS Chromium. The new unwrapLayers PostCSS plugin removes generated @layer wrappers, including nested layers, and the PostCSS configuration appli…
Out of Scope Changes check
The reviewed changes are limited to the PostCSS pipeline and the layer-unwrapping plugin. Both changes support the display fix for issue #714. No unrelated behavior or files are identified in the supp…
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.
✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
Commit to this branch
Create a new PR
📝 Generate docstrings
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
I was seeing some minor display issues with an older iPad. These also seem to be resolved with this PR.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #714
Summary by CodeRabbit