Repository navigation
Options objects - #58
Merged
Merged
Conversation
Every method with optional arguments takes them as an options object
too: the resize methods ({mode}), opacity/red/green/blue/lightness/
saturation ({absolute}), composite ({x, y, opacity, mode}), sharpen
({amount, radius}), the encoders ({compression|quality, metadata}),
renderSVG ({size, mode}), renderText ({color, layout, ...style}),
Frame and Frame.from ({duration, xOffset, yOffset, disposalMode}),
Animation ({loopCount}), Animation.decode() and decode()
({onlyFirstFrame}, decode() also {applyOrientation}). The positional
arguments keep working.
encode() still takes metadata as its first argument: metadata and the
options have no key in common. The metadata arguments the other
encoders got for 3.2.0 (unreleased) are options only.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MLHc7GW46D6BmwtEM2khgr
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MLHc7GW46D6BmwtEM2khgr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every method with optional arguments now also takes them as an options object, so options can be left out or added without counting positions:
Covered: the resize methods,
opacity/red/green/blue/lightness/saturation,composite,sharpen,roundCorners,fisheye, every encoder,renderSVG,renderText,FrameandFrame.from,Animation,Animation.decode()anddecode()(onlyFirstFrame,applyOrientation).encode()still takes metadata as its first argument, because metadata and the options don't share any keys.metadataoption, so no new positional arguments are released.