OF-3371: Disable test whilst issue remains open - #3500
Conversation
Right now, offline messages aren't removed. But we also don't have a MAM implementation for this. XEP-0386 removes the offline messages _because_ they'll come from MAM. So keeping offline messages makes sense for now. This proactively disables the test that's not yet in the main branch of SINT Server Extensions.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe CI workflow adds Suggested reviewers: Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to This change only skips the intended interop test while the known upstream issue remains open, with no additional merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
guusdk
left a comment
There was a problem hiding this comment.
Looks good to me. Let's not forget that this does not close OF-3371 upon merge.
Right now, offline messages aren't removed. But we also don't have a MAM implementation for this. XEP-0386 removes the offline messages because they'll come from MAM. So keeping offline messages makes sense for now.
This proactively disables the test that's not yet in the main branch of SINT Server Extensions.