Skip to content

OF-3371: Disable test whilst issue remains open - #3500

Merged
Fishbowler merged 1 commit into
igniterealtime:mainfrom
Fishbowler:OF-3371-disable-test
Sep 14, 2026
Merged

Fishbowler merged 1 commit into
igniterealtime:mainfrom
Fishbowler:OF-3371-disable-test

Conversation

@Fishbowler

Copy link
Copy Markdown
Member

Right now, offline messages aren't removed. But we also don't have a MAM implementation for this. XEP-0386 removes the offline messages because they'll come from MAM. So keeping offline messages makes sense for now.

This proactively disables the test that's not yet in the main branch of SINT Server Extensions.

Right now, offline messages aren't removed. But we also don't have a MAM implementation for this. XEP-0386 removes the offline messages _because_ they'll come from MAM. So keeping offline messages makes sense for now.

This proactively disables the test that's not yet in the main branch of SINT Server Extensions.
@Fishbowler
Fishbowler requested a review from guusdk September 14, 2026 10:14
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: ddd12581-dfff-4361-9c72-7de7428cb4a6

📥 Commits

Reviewing files that changed from the base of the PR and between d2e08dd and 18ae0f6.

📒 Files selected for processing (1)
  • .github/workflows/continuous-integration-workflow.yml

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The CI workflow adds Bind2NegotiationIntegrationTest.testOfflineMessagesNotDeliveredOnBind to the XMPP interop action's disabledTests list. The test is skipped during XMPP interop runs.

Suggested reviewers: guusdk

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 18ae0

This change only skips the intended interop test while the known upstream issue remains open, with no additional merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description explains that the pull request disables an offline-message test because Openfire retains offline messages until MAM support is available. This matches the workflow change.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@guusdk guusdk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's not forget that this does not close OF-3371 upon merge.

@Fishbowler
Fishbowler merged commit 45a2f24 into igniterealtime:main Sep 14, 2026
48 checks passed
@Fishbowler
Fishbowler deleted the OF-3371-disable-test branch September 14, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants