Repository navigation
Key the callback blob test gate by the store's canonical root - #434
Merged
Merged
Conversation
The callback blob race tests installed their I/O gate under the raw tempdir path. RuntimeStore canonicalizes its state root, so on macOS the blob code looks up /private/var/... while the gate waits under /var/.... The gate never fired, and 6 of the 9 tests timed out at the arrival guard on every macOS run. Use store.state_dir(), the path the blob code receives.
Owner
Author
Owner
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On macOS, 6 of the 9
callback_blob_*tests insends_tests.rsfail on every run withElapsedat the arrival guard (sends_tests.rs:1086). Reproduced alone on origin/main 23fc606: 3 passed, 6 failed, 17.65 s.callback_blob_caseinstalls its I/O gate underdirectory.path(), the raw tempdir path (/var/folders/...).RuntimeStore::opencanonicalizes the state root (resolve_explicit_state_dir), so the blob code callstest_io_gatewith/private/var/folders/.... The keys never match, the gate never fires, and the test waits 10 s for an arrival that cannot come. Linux has no/varsymlink, so the tests pass there.Change
Key the gate by
store.state_dir(), the root the blob code receives. Test-only change; no product code changes.Tests
cargo test -p studio-runtime-services --lib callback_blobon macOS: before 3 passed, 6 failed; after 9 passed (7.43 s).just test-fast: result below.