Skip to content

fix(phone): report app discovery and initialization failures #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ifBars merged 1 commit into from
Oct 4, 2026
Merged

fix(phone): report app discovery and initialization failures #346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions S1API/Internal/Patches/HomeScreen.Start.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,16 @@ static void Postfix(HomeScreen __instance)
ExternalAppCatalog.Clear(ExternalAppFamily.Phone);
// Re-register all PhoneApps
var phoneApps = ReflectionUtils.GetDerivedClasses<PhoneApp.PhoneApp>();
Logger.Msg($"Discovered {phoneApps.Count} custom phone app type(s).");
foreach (var type in phoneApps)
{
Logger.Debug($"Found phone app: {type.FullName}");

if (type.GetConstructor(Type.EmptyTypes) == null)
{
Logger.Warning($"Skipping phone app {type.FullName}: a public parameterless constructor is required.");
continue;
}

Logger.Msg($"Initializing phone app: {type.FullName}");

try
{
Expand All @@ -62,7 +66,7 @@ static void Postfix(HomeScreen __instance)
}
catch (Exception e)
{
Logger.Warning($"[PhoneApp] Failed to register {type.FullName}: {e.Message}");
Logger.Warning($"Failed to register phone app {type.FullName}: {e}");
}
}
}
Expand Down
Loading