Repository navigation
fix: safely tokenize CSS unit conversions and preserve lifecycle context - #51
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSS unit conversion currently uses a regex that can partially match identifiers, lose signed/scientific values, and stop protecting nested
var()fallbacks. This change tokenizes complete CSS dimensions by default, preserving strings and URLs, and applies minimum values by absolute magnitude. ExplicitunitRegexremains available.The shared walker gains an optional whole-value transformer and importance-aware fallback deduplication. Programmatic ASTs receive a temporary Input context without fabricated source metadata. Legacy wrappers preserve their matching behavior and forward native PostCSS lifecycle helpers. Preset factories accept public and custom option interfaces.
Release intents: minor for
postcss-plugin-shared; patch forpostcss-rule-unit-converter, with dependent-package updates handled by the release plan. This PR does not publish npm packages or merge a version PR.Validation: workspace build/lint/typecheck, 405 tests across all consumers, converter per-file 100% coverage, TSD, packed ESM/CJS and subpath checks, website build, repo doctor/check. Bilingual API and migration documentation describe first-match rules, single-pass conversion, repeated processing, and entry-level exclusions.