Repository navigation
ch_func_to_all_pk: explicit excess_keywords policy, default unchanged (#95) - #100
Merged
Merged
Conversation
…fault unchanged; clear error for a stray positional (#95) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…s() (as **) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #95 without changing any default behaviour (i2 is a foundation package; meshed's
hook_uprelies on drop without*args, while the 0.1.75 doctest documents forward with*args, so no single default can be strictly compatible).excess_keywords=None|"drop"|"forward".None(default) = the historical per-path rule, so existing calls are unchanged;"drop"/"forward"give one rule on either path (both paths now share the all-PK machinery).ch_func_to_all_pk(f4)(1, 2, 3)→dict() argument after ** must be a mapping) now raises a clearTypeError(stillTypeError; anything withkeys()is still accepted, as for**).Verification: differential test of old (master) vs new default over 16,848 calls × 9 callable shapes: 0 mismatches. i2: 819 tests + doctests pass; meshed and py2http decorators tests pass. Dependents gate (
priv test-dependents i2 --transitive): 101 dependents, statuses identical to the master baseline (config2py, ef, grub failed in the baseline run and passed with the change, i.e. flaky, not a regression; 20 pre-existing failures in both).Adversarial review (fresh Opus, 229,600-call differential): found one real incompatibility (my stray-positional check required a
Mapping, master accepted any object withkeys(), e.g. a pandas Series); fixed and tested. Callers meshed, py2http andi2.multi_objectverified unaffected.Closes #95
🤖 Generated with Claude Code