Repository navigation
feat: dol.key_in_scope(store, k), a non-writing filt_iter scope probe (#129) - #130
Merged
Merged
Conversation
thorwhalen
added a commit
that referenced
this pull request
Oct 13, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…robe (#129) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
thorwhalen
force-pushed
the
feat/key-in-scope-129
branch
from
October 13, 2026 11:55
7f55c0a to
6d39b6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #129.
filt_iterrecords its predicate on its layer class (_filt_iter_filts);key_in_scope(store, k)followskthrough the.storelayers outermost first, applies each layer's predicates to the key as it enters that layer (what a write does), maps it with_id_of_key, and finally asks a leaf that hasis_valid_key(e.g.Files). No reads or writes. Only a class's own record counts (Store wrappers delegate inner attributes asDelegatedAttribute, which would attribute an inner predicate to the outer layer).Adversarial review (Opus): agreed with the real write/
infor every stacking tried (filt_iter, wrap_kvs, KeyCodecs, Pipe, cached_keys, add_prefix_filtering, cache_vals, mk_dirs_if_missing; class and instance; both orders; set/list/generator filters; subclasses; MI; pickling/deepcopy; Files coordinates). Gaps found and documented in the docstring (no code change): layers that look keys up themselves while keeping the identity_id_of_key(add_path_access,flatten) give a silently wrong answer; the probe raises whatever a layer's_id_of_keyraises; a subclass changing the key inside__setitem__.Dependents gate: pending (the new attribute only touches
filt_iterclasses).🤖 Generated with Claude Code