Repository navigation
Keep MaybeBackoff waiting after 15 minutes - #2
Merged
Merged
Conversation
MaybeBackoff::arm() built an ExponentialBackoff without setting max_elapsed_time, so it kept the default limit of 15 minutes. After that, next_backoff() returned None and sleep() returned at once. Loops that retry forever then retried with no delay. Remove the elapsed-time limit, add a regression test, and bump the version to 0.5.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaybeBackoff::arm()now builds itsExponentialBackoffwith no elapsed-time limit. An armedMaybeBackoffkeeps waiting between attempts for as long as the caller retries.Problem
arm()set the initial delay, the maximum delay, the multiplier, and the randomization factor. It did not setmax_elapsed_time, so the backoff kept theExponentialBackoffdefault of 15 minutes. After 15 minutes,next_backoff()returnedNone, andsleep()returned at once. A loop that retries forever then retried with no delay at all.Changes
arm()calls.with_max_elapsed_time(None). Its doc comment now says that an armedMaybeBackoffalways waits and never runs out.start_timeback by 16 minutes and checks thatnext_backoff()still returns a delay. The test fails without the fix.Checks
cargo test --features tokiocargo test --doccargo fmt -- --checkcargo clippy --all-targets --features tokio -- -D warningscargo clippy --all-targets --target wasm32-unknown-unknown -- -D warnings