Repository navigation
ci: fix cargo deny advisories and drawer focus e2e race - #1
Merged
Merged
Conversation
clipboard-win 5.4.1 is yanked. arboard 3.6.1 accepts ^5.3.1, so the lockfile now pins 5.4.3. zvariant, zvariant_derive, and zbus_names were folded into zbus 6 and have no patched release. They only arrive through accesskit's AT-SPI stack, via bevy_winit and egui-winit. accesskit_unix 0.24.1 still depends on zbus 5, and Bevy 0.20 has not moved off it, so the advisories stay ignored until that migration exists. Co-authored-by: Pot <pot@hyperlogue.tech>
The drawer-focus step opens sample.clm while the previous step still has that model on screen. The face row is already there, so the click selects the session openFile is about to replace. On the connected backend that replacement lands during the focus checks, clears the selection, and disables Delete, so Shift+Tab no longer lands on it. In-tab wasm usually finishes first, which is why only the connected pass failed. Co-authored-by: Pot <pot@hyperlogue.tech>
1.14.0 is yanked. 1.14.1 is the compatible release, so the lockfile moves to it and nothing else changes. Co-authored-by: Pot <pot@hyperlogue.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked onto current main from neopot/catchlight
cursor/fix-deny-and-drawer-focus-1663(402a8e1).^5.3.1, so the lockfile pins 5.4.3.Cargo.lockis the only file changed.zvariant,zbus_names, andzvariant_derivearrive only viaaccesskit_unix->atspi->zbus5, and the newestaccesskit_unixstill needszbus5. Remove the ignores once AccessKit moves tozbus6.openFilewas about to replace. It now waits for the opened copy to be the current session and for the face row to exist before clicking. Product code is unchanged.Checks that passed on the fork: cargo deny, e2e on both backends,
cargo fmt --check, clippy-D warnings.Fresh checks on this branch:
nix develop -c bun run --filter catchlight-demo e2epassed on the previous head, including the drawer-focus step on in-tab WebGPU, connected WebGPU, and in-tab WebGL2. This follow-up only changesCargo.lock.nix develop -c cargo deny checknow fully passes (advisories ok, bans ok, licenses ok, sources ok) after the async-executor bump.