Name the issue derivePickedClients resolves, not only the decision - #598
Conversation
LLP 0177's fix shipped in #594, but no @ref pointed at it anywhere, so neutral observe reported it as an uncovered request - the Designer's input. Acting on that gap would mint a design and an integration branch for a bug already fixed, the same shape as #589. LLP 0180 cites 0177 in Related: and in prose, but coverage derives from @ref annotations, so none of it registered. The ref earns its place: derivePickedClients exists in this shape because the picker's client list was a hardcode the manifest could not reach, which is not visible from the code or the filename. Fixes #597
Review: cleanDisclosure: reviewed by the reconciler that authored it, not by an independent agent. A deliberate proportionality call for a two-line comment-only diff, recorded so a reader can weigh it. Anything with behavior in it gets an independent reviewer. DiffOne file, two added lines, comment-only:
Is the annotation honest?That is the only thing worth checking here, since
Does it achieve its purpose?The gap it closes is real: Gates
|
One added
@refonderivePickedClients(src/core/cli/walkthrough.js), naming LLP 0177 alongside the existing@ref LLP 0180#decision.Why this is worth a PR
LLP 0177's fix shipped in #594, but no
@ref LLP 0177existed anywhere in the tree, soneutral observereported it as backlog:An uncovered request is the Designer's input. Acting on that gap would mint a fresh design LLP for a bug fixed hours earlier and push
integration/picker-enables-openclaw-without-attaching. The reconciler tick that opened this deliberately skipped it.Same shape as #590 (LLP 0174 left
Acceptedafter its change set shipped, re-deriving asimplementable). Both are cases where the work is done but the marker that makes "done" derivable was never written.LLP 0180 does cite 0177 heavily, in
**Related:**and in its Consequences ("LLP 0177 is resolved"), but coverage derives from@refannotations rather thanRelated:lines or prose, so none of it registered.On the annotation itself
CLAUDE.mdwarns against annotating mechanically, so to be explicit about why this one earns its place: it records thatderivePickedClientsexists in this shape because the picker's client list was a hardcode the manifest could not reach. That is the motivation for the whole derivation, and it is not visible from the code or the filename. The sibling@ref LLP 0180#decisionnames the decision taken; this one names the defect that forced it.Verification
neutral observe --jsonreportsbacklog: []and nollp#177gap once this lands.npm test: 3375 tests, 3374 pass, 1 skipped, 0 fail.npm run typecheck: clean.Fixes #597