Fix: align full-rank chip run activation - #1967
Draft
high-cloud wants to merge 4 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
high-cloud
force-pushed
the
stabilize-chip-run-completion
branch
from
August 23, 2026 16:13
f193d90 to
a09ec67
Compare
Stage every local full-rank member through native prepare and activate the group only after all members report ready. Cancel prepared peers when any member fails so a rank cannot enter runner_run ahead of the group. Let the resident chip-run lane own completion, predecessor retirement, and successor launch. Block idle child workers on a mailbox generation and wake them only for explicit notifications, preserving depth-two asynchronous device occupancy without Python polling or per-state futex syscalls.
high-cloud
marked this pull request as draft
August 23, 2026 16:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stabilize multi-rank chip runs under a sustained depth-two asynchronous workload.
runner_runstart.This is the Simpler runtime part of hw-native-sys/pypto-serving#179. PyPTO group metadata/codegen counterpart: hw-native-sys/pypto#2490.
Verification
117/117 passed.923 passed, 3 skipped.2/2 passed, withdeps.jsonproduced.4/4 passed(task_20260823_100011_126283323169, exit 0).1/1 passed(task_20260823_102832_2163987332, exit 0).task_20260823_103208_224612532435, exit 00.047/0.056/0.072/0.470 ms0.020/0.041/0.112/4.657 ms0.140/1.048/1.650/4.658 ms0.073/0.423/2.153/0.054/3.723 ms; no >5 ms samples8192/8192tokens,426.909 tok/s, task exit 0.0.096/1.089 ms, with no >5 ms late start0.052 ms; validate max:0.227 msThe Serving run still observed seven random-rank runner-end skews above 5 ms (maximum
7.420 ms). Device-phase markers were disabled in the acceptance run, so this PR does not claim that every residual completion/fence tail is eliminated.