Add: test host input refresh across L3 dispatches - #1856
Conversation
Exercise repeated in-place updates of small ID tensors and larger activation tensors across two reused L3 workers. Validate that every dispatch stages the current fork-shared host values before AICore execution, covering the stale-input failure reported in issue hw-native-sys#929.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughThis change adds an AIC copy kernel and orchestration entry points. A scene test updates shared host inputs across multiple rounds and verifies refreshed INT64 and FP32 outputs for two ranks. ChangesHost input refresh
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This PR adds targeted coverage for refreshing host inputs across repeated dispatches without changing production behavior; no actionable merge-blocking risk remains beyond normal checks and review. Sequence Diagram(s)sequenceDiagram
participant SceneTest
participant Orchestration
participant AICKernel
participant SharedHostMemory
SceneTest->>SharedHostMemory: update ID and activation inputs
SceneTest->>Orchestration: dispatch retained task arguments
Orchestration->>AICKernel: submit mapped input and output tensors
AICKernel->>SharedHostMemory: read refreshed inputs
AICKernel->>SharedHostMemory: write outputs and flush cache lines
SceneTest->>SharedHostMemory: validate refreshed outputs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Exercise repeated in-place updates of small ID tensors and larger activation tensors across two reused L3 workers.
Validate that every dispatch stages the current fork-shared host values before AICore execution, covering the stale-input failure reported in issue #929.