Skip to content

Add: test host input refresh across L3 dispatches - #1856

Open
vegetabledoww wants to merge 1 commit into
hw-native-sys:mainfrom
vegetabledoww:fix/issue-929-task-frame-input-refresh
Open

Add: test host input refresh across L3 dispatches#1856
vegetabledoww wants to merge 1 commit into
hw-native-sys:mainfrom
vegetabledoww:fix/issue-929-task-frame-input-refresh

Conversation

@vegetabledoww

Copy link
Copy Markdown
Contributor

Exercise repeated in-place updates of small ID tensors and larger activation tensors across two reused L3 workers.

Validate that every dispatch stages the current fork-shared host values before AICore execution, covering the stale-input failure reported in issue #929.

Exercise repeated in-place updates of small ID tensors and larger activation tensors across two reused L3 workers.

Validate that every dispatch stages the current fork-shared host values before AICore execution, covering the stale-input failure reported in issue hw-native-sys#929.
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: dbab8950-3e2f-41ab-a657-27d8dcb93839

📥 Commits

Reviewing files that changed from the base of the PR and between ad4acaf and 5370015.

📒 Files selected for processing (3)
  • tests/st/a2a3/tensormap_and_ringbuffer/host_input_refresh/kernels/aic/kernel_copy_first.cpp
  • tests/st/a2a3/tensormap_and_ringbuffer/host_input_refresh/kernels/orchestration/copy_first_orch.cpp
  • tests/st/a2a3/tensormap_and_ringbuffer/host_input_refresh/test_host_input_refresh.py

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

This change adds an AIC copy kernel and orchestration entry points. A scene test updates shared host inputs across multiple rounds and verifies refreshed INT64 and FP32 outputs for two ranks.

Changes

Host input refresh

Layer / File(s) Summary
AIC copy kernel
tests/st/a2a3/tensormap_and_ringbuffer/host_input_refresh/kernels/aic/kernel_copy_first.cpp
Adds kernel_entry, which copies ID and activation inputs to outputs and flushes both output cache lines.
Orchestration task wiring
tests/st/a2a3/tensormap_and_ringbuffer/host_input_refresh/kernels/orchestration/copy_first_orch.cpp
Adds configuration and entry functions that map four tensors and submit the AIC task.
Repeated scene validation
tests/st/a2a3/tensormap_and_ringbuffer/host_input_refresh/test_host_input_refresh.py
Adds two-rank callable setup, shared-memory tensors, repeated input updates, task dispatches, output assertions, cleanup, and standalone execution.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 53700

This PR adds targeted coverage for refreshing host inputs across repeated dispatches without changing production behavior; no actionable merge-blocking risk remains beyond normal checks and review.

Sequence Diagram(s)

sequenceDiagram
  participant SceneTest
  participant Orchestration
  participant AICKernel
  participant SharedHostMemory
  SceneTest->>SharedHostMemory: update ID and activation inputs
  SceneTest->>Orchestration: dispatch retained task arguments
  Orchestration->>AICKernel: submit mapped input and output tensors
  AICKernel->>SharedHostMemory: read refreshed inputs
  AICKernel->>SharedHostMemory: write outputs and flush cache lines
  SceneTest->>SharedHostMemory: validate refreshed outputs
Loading

Poem

A rabbit hops through buffers bright,
Refreshing IDs in morning light.
Activations follow, outputs gleam,
Cache lines flush beside the stream.
Two ranks check each changing round,
And clean task arguments from the ground.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the added test for host input refresh across repeated L3 dispatches.
Description check ✅ Passed The description explains the repeated updates, reused L3 workers, validation, and stale-input issue covered by the changes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant