Expose Progressive::timeOut() to Python - #178
Open
thanhndv212 wants to merge 2 commits into
Open
Conversation
hpp-core's continuousValidation::Progressive gained a configurable timeOut() getter/setter (humanoid-path-planner/hpp-core#450, replacing a hardcoded 15s wall-clock bound in validateStraightPath()). Bind it so it's reachable from Python, not just C++ — otherwise it isn't actually usable by any of this project's downstream consumers, which only interact with hpp-core through these bindings. pv->obj is the generic PathValidationPtr_t stored by the PathValidation wrapper; downcast to continuousValidation::ProgressivePtr_t to reach the concrete method, same pattern as the existing PVWrapper helpers for validate()/validateConfiguration().
for more information, see https://pre-commit.ci
thanhndv212
marked this pull request as draft
August 7, 2026 18:02
thanhndv212
marked this pull request as ready for review
August 7, 2026 18:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
continuousValidation::Progressivegained a configurabletimeOut()getter/setter in hpp-core (humanoid-path-planner/hpp-core#450), replacing
a hardcoded 15s wall-clock bound in
validateStraightPath(). This bindsit so it's reachable from Python — without it, the new setting isn't
actually usable by any project that only talks to hpp-core through these
bindings (as opposed to linking hpp-core directly).
Depends on hpp-core#450 — needs that PR's
Progressive::timeOut()C++ method to exist before this can build.
Change
pathValidation::Progressive's pybind wrapper stores the concretevalidator behind a generic
PathValidationPtr_t. Added aProgressiveWrapperwith static getter/setter functions that downcastto
continuousValidation::ProgressivePtr_tviaHPP_DYNAMIC_PTR_CAST,matching the existing
PVWrapperpattern already used forvalidate()/validateConfiguration(). Bound as an overloadedtimeOutmethod (get with no args, set with a
floatarg) on theProgressivePython class.
Testing
Built against a local hpp-core checkout with #450's changes applied;
verified from Python: