docs(rules): lint markdown at commit, not push - #170
Merged
Merged
Conversation
Time Submission Status
Submit or update total time with: Add time on top of previous submission with: See available commands to help comply with our Guidelines. |
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
angelicawill
marked this pull request as ready for review
September 24, 2026 11:38
Contributor
Author
|
@teodorus-nathaniel @williamrusdyputra ready for review, thanks! @holdex pr add-time 5m |
Contributor
|
reviewing |
williamrusdyputra
approved these changes
Sep 24, 2026
williamrusdyputra
left a comment
williamrusdyputra
left a comment
Contributor
There was a problem hiding this comment.
@holdex pr add-time 8m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves holdex/marketing#1155
Why
Checking at push time was annoying:
Checking at commit time only looks at the files you staged, and fixes go into the same commit.
What changes
lefthook.ymlruns the checks on commit.scripts/hook-env.shmakes the hook work in GitHub Desktop and in folders with spaces in the name.Needs approval
DEV-380 is a rule change. @zolotokrylin, please confirm.
How to use
npm installonce.LEFTHOOK=0 git commit. CI still checks the PR.Tested
npm install: works, or skips with a note