chore(hooks): run push checks from one lefthook config - #169
Merged
Merged
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Time Submission Status
Submit or update total time with: Add time on top of previous submission with: See available commands to help comply with our Guidelines. |
angelicawill
marked this pull request as ready for review
September 23, 2026 10:09
Contributor
Author
|
@holdex pr add-time 15m |
angelicawill
requested review from
zolotokrylin
and removed request for
zolotokrylin
September 23, 2026 10:17
Contributor
Author
|
@williamrusdyputra @teodorus-nathaniel @zolotokrylin ready for review |
Contributor
|
log: reviewing |
williamrusdyputra
approved these changes
Sep 23, 2026
Contributor
|
@holdex pr add-time 14m |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves pre-push hooks to lefthook and updates DEV-380 so all repos use the same setup.
partially resolves holdex/marketing#1155
Why
The old setup manually figured out which files changed in a push, with the same logic duplicated across multiple files and repos.
lefthook already handles this with
{push_files}, including a branch's first push.What changes
lefthook.ymlnow runs the markdown, authoring, and rules checks.hooks.ymlruns the same setup in CI..githooks/pre-pushandrules_audit.ymlare removed.markdown_lint.ymlstill checks commit and PR titles..githooks.Known limit
lefthook skips hooks on delete-only pushes. Since deleting a rule can still break dependencies, CI also runs
check-rules.mjs --rulesseparately.After merge
Run
npm installonce to remove the oldcore.hooksPathsetting and install lefthook.Testing
Tested locally:
This will be the first run of
hooks.ymlon GitHub.