fix(shared): declare missing @finagent/skill-hub workspace dependency - #8
Open
kbkb628 wants to merge 1 commit into
Open
fix(shared): declare missing @finagent/skill-hub workspace dependency#8kbkb628 wants to merge 1 commit into
kbkb628 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
packages/shared有 5 个源文件直接 import@finagent/skill-hub（src/strategies/presets.ts、src/kernel/agent-kernel.ts、src/agent/pi-runtime-adapter.ts、src/agent/workspace-context.ts及对应测试），但shared/package.json的dependencies中没有声明该依赖，目前仅靠 Bun 的依赖提升才能解析，属于隐式依赖。改动
packages/shared/package.json补充"@finagent/skill-hub": "workspace:*"（顺带按字母序整理 dependencies）。验证
bun run typecheck全绿bun test packages/shared746 通过 / 0 失败